Commit Graph

1678 Commits

Author SHA1 Message Date
Kienan Stewart 16ff2ead31 Fix warning when a user has many scheduled tasks to run
When a user has more than m_cron::MAX_SOCKETS actions to run when the
cron script is invoked, it uses a rolling window while running the
batch execution in CURL. The followin warning happens because the
url key isn't being used when getting the information out of the array.
2023-09-28 08:58:44 +02:00
Kienan Stewart ef21e3e144 Fix tabs/spacing 2023-09-28 08:53:09 +02:00
Guillaume Est Une Palourde a675041874 Set the disabled flag so its not permanently pending when disabling domains 2023-09-28 08:52:41 +02:00
Guillaume Est Une Palourde 36563f7298 Added a return value so query that sets the result and resets the action to OK don't crash 2023-09-28 08:52:18 +02:00
Kienan Stewart e028b15e7b Hide matomo users who have access to a site but not made by AlternC
Users made in the Matomo interface and given an access to a site
that's in AlternC show up without this restriction. When that happens,
the user is no longer able to modify permissions for any of the Matomo
users from their AlternC account.
2023-09-28 08:49:07 +02:00
Kienan Stewart c95dd63c26 Remove trailing whitespace 2023-09-28 08:48:39 +02:00
Kienan Stewart e3a59dd504 Remove trailing '.' from the return values of m_dom::whois()
The answer from dig is typically fully qualified with a trailing '.',
but the callers of whois() expect the nameservers without that trailing dot.
2023-09-27 18:09:56 +02:00
Kienan Stewart c59bdce1f3 Add hook to allow adding bind tokens 2023-09-27 18:08:38 +02:00
Kienan Stewart ba199de626 Remove maxlength specific from e-mail password and confirmation fields
Fixes #382

The maxlength attribute will silently drop all characters after the
indicated limit. Users will not have feedback that their password
is (now) wrong.

There seems to a password policy that is actively checked, and may be
defined by the admin (default: 64 character limit).
2023-09-27 18:07:11 +02:00
Kienan Stewart 6e7f751dc5 Mark DKIM records for deletion instead of deleting immediately
Refs #349
2023-09-27 17:55:08 +02:00
Kienan Stewart 9cfc9f359b Handle TXT records longer than 255 characters properly
Refs #349
2023-09-27 17:49:31 +02:00
Kienan Stewart 4687bff96d Bump default DKIM key length to 2048
This matches the Debian default for opendkim-genkey

Refs #337
2023-08-30 12:31:43 +02:00
Kienan Stewart 7523d6bebf Delete the correct private DKIM key during DKIM deletion
Fixes #338
2023-08-30 12:30:53 +02:00
Kienan Stewart a00f4b0d5f Check if domain is being deleted before adding DKIM key entry
Fixes #338
2023-08-30 12:30:23 +02:00
Km 72d0a8e47e
Merge pull request #342 from Koumbit/339_bind_conf_with_multiple_domains
Filter generated bind configuration by current domain
2023-08-30 12:27:44 +02:00
Kienan Stewart 43d97f1c57 Order enumerated mails for a domain by ascending alphabetic order
Fixes #341

When applying LIMIT X, Y the ordering before the limit and offset do
not seem to be guaranteed. For example, if you have a large number of
e-mail addresses, and you page between the same e-mail address can appear twice.

The case where this was happening there were 2-3 mail boxes and ~90 aliases.

I'm not sure if this tied somehow to the database version used, but making the
desired ordering explicit ensures that all mails will eventually be shown and
shouldn't be shown twice.
2023-08-30 12:17:50 +02:00
Km c80814c4eb
Merge pull request #307 from Koumbit/102-password_recovery
Issue #102: Add password reset via one-time login link
2023-08-30 12:15:45 +02:00
Kienan Stewart afafb3e4f6 Fix script invocation when scanning a directory
Since the directory was not preprended to the filenames, no scripts
could ever be called.
2023-08-30 12:08:30 +02:00
Kienan Stewart b9b0f6181b Indicate unknown for the HTTPS state of a sub-domain only when the type has an https option 2023-08-30 10:01:56 +02:00
Kienan Stewart a9f6e757cd Match type more broadly for vhost when searching subdomains 2023-08-21 13:22:23 +02:00
Km 937339befb
Merge pull request #414 from Koumbit/413-bind_reloads_every_minute
Fix #413: Add return values for bind update domains hooks
2022-09-23 21:53:18 +02:00
Kienan Stewart 2e1fbd374d Fixes #441: Correct DMARC entry syntax 2021-06-16 17:08:54 +02:00
alban 78d3aeb60f [fix] There should be no <script> markup in tables headers #402 2020-07-02 22:54:26 +02:00
Kienan Stewart d373365d8f
Fix #413: Add return values for bind update domains hooks
hook_updatedomains_dns_{add,del} have their return values checked in
m_dom::update_domains() to set the dns_result column.

When no return value is specified, the value is actually NULL and doesn't
get mapped to an integer value that is expected by the dns_result column.

As a result, the query fails silently and the DNS_ACTION column is never
updated. This causes update_domains to retry the same modification on
every run.
2020-06-08 17:40:40 -04:00
Km b057544ba3
Merge pull request #372 from UdelaRInterior/fix-#326
Fix #326 - Minor detail in form
2020-01-28 18:39:31 +01:00
Louis-Philippe Véronneau a10f67f299
fix minor typo 2019-09-09 15:39:50 -04:00
santiagomr 5ca85e7357 Fix #326 - Minor detail in form 2019-07-15 15:10:39 -03:00
Km 5e9fadd315
Merge pull request #329 from Koumbit/matomo_integration_fixes
Matomo integration fixes
2019-07-12 22:54:17 +02:00
Km db471afa79
Merge pull request #343 from Koumbit/336_domaine_deletions_stuck
Fix domain deletion query
2019-07-12 21:35:45 +02:00
Km 200f103adf
Merge pull request #347 from Koumbit/335_phpmyadmin_sso_broken
Fixes #335: Fix PHPMyAdmin Single-signon errors
2019-07-12 21:33:15 +02:00
Kienan Stewart bb6d5c6863
Fix insert query failure during import_cert
The sslcsr is just set to an empty string so that the query works properly.
Without it, queries fail since sslcsr does not have a default value set.

Improved the detail of the messages logged during the failure of that query as well.
2019-07-12 14:46:36 -04:00
Kienan Stewart 70184caa3a
Return an error when attempting to connect to PHPMyAdmin with no DBs
Refs #335
2019-05-14 12:14:25 -04:00
Kienan Stewart f6860ed2be
Use pma_sso script to connect PhpMyAdmin from admin menu
Refs #335
2019-05-14 12:13:44 -04:00
Kienan Stewart 39dba8188b
Fix domain deletion query
Fixes #336
2019-05-13 17:28:05 -04:00
Kienan Stewart 753c27a9cf
Fix typo in query to update domain type
Fixes #339
2019-05-13 17:12:05 -04:00
Kienan Stewart 1dbe646724
Filter generated bind configuration by current domain
Fixes #339
2019-05-13 16:40:27 -04:00
Kienan Stewart d299462439
Fix typo in table alias causing zone data queries to fail 2019-04-23 12:16:31 -04:00
Kienan Stewart e6c042331d
Do not add bind entries for sub domaines marked for deletion
Fixes #328
2019-04-12 16:38:07 -04:00
Kienan Stewart 0956906e98
Request unlimited number of a sites from matomo
By default, matomo applies a limit of 100 results to all API endpoints
that return an array. By passing filter_limit -1 all results can be
fetched in a single call for the site lists.

Ref: https://developer.matomo.org/api-reference/reporting-api
2019-04-05 13:48:03 -04:00
Kienan Stewart 5a62d13843
Store the proper hash of a matomo user's password 2019-04-05 13:47:53 -04:00
Kienan Stewart 3b46081292
Add password reset via one-time login link
Closes #102
2018-11-14 19:05:32 -05:00
Benjamin Sonntag 03e1786159 [fix] fix dmarc and spf not working 2018-10-25 17:33:21 +02:00
Benjamin Sonntag 5fb091660e [fix] error with dom lock in m_dom 2018-10-25 15:55:39 +02:00
Benjamin Sonntag 27f907ee99 [fix] (for 3.5) delete ALSO autoconf / autodiscover in cascade when del_mx_domain 2018-10-23 19:27:54 +02:00
Benjamin Sonntag ad6bb372ea [fix] (for 3.5) delete DMARC and SPF and DKIM in cascade when del_mx_domain 2018-10-23 19:23:14 +02:00
Benjamin Sonntag b50f028e0e [fix] (for 3.5) delete DMARC and SPF and DKIM in cascade when del_mx_domain 2018-10-23 19:21:22 +02:00
Benjamin Sonntag ca0ed3dd40 [fix] (for 3.5) fixing longstanding bug when we didn't deleted (or deleted too many) vhosts files in /var/lib/alternc/apache-vhost/. 2018-10-23 19:02:15 +02:00
alban ad17a8715b [fix] Translations : fix translations 2018-10-23 16:37:51 +02:00
alban abcc48b77d [fix] Translations : remove some fuzzy translations and fix #298 2018-10-23 16:35:04 +02:00
Kienan Stewart ad201fd4f2 Fix syntax error in bro_editor 2018-10-22 17:14:48 +02:00