(PDOC-63) Implement a Puppet defined type YARD handler.

This commit implements a YARD handler for Puppet defined types and the
associated code object and templates.
This commit is contained in:
Peter Huene 2016-09-11 11:27:26 -07:00
parent 7c3cd5463c
commit 187dec9cee
No known key found for this signature in database
GPG Key ID: 6B585C1742BE3C3C
14 changed files with 146 additions and 3 deletions

View File

@ -30,6 +30,7 @@ class YARD::CLI::Yardoc
:module,
:class,
:puppet_class,
:puppet_defined_type,
)
end
end
@ -42,6 +43,10 @@ class YARD::CLI::Stats
output 'Puppet Classes', *type_statistics_all(:puppet_class)
end
def stats_for_puppet_defined_types
output 'Puppet Defined Types', *type_statistics_all(:puppet_defined_type)
end
def output(name, data, undoc = nil)
# Monkey patch output to accommodate our larger header widths
@total += data if data.is_a?(Integer) && undoc

View File

@ -1,4 +1,5 @@
# The module for custom YARD code objects.
module PuppetStrings::Yard::CodeObjects
require 'puppet-strings/yard/code_objects/class'
require 'puppet-strings/yard/code_objects/defined_type'
end

View File

@ -0,0 +1,44 @@
require 'puppet-strings/yard/code_objects/group'
# Implements the group for Puppet defined types.
class PuppetStrings::Yard::CodeObjects::DefinedTypes < PuppetStrings::Yard::CodeObjects::Group
# Gets the singleton instance of the group.
# @return Returns the singleton instance of the group.
def self.instance
super(:puppet_defined_types)
end
# Gets the display name of the group.
# @param [Boolean] prefix whether to show a prefix. Ignored for Puppet group namespaces.
# @return [String] Returns the display name of the group.
def name(prefix = false)
'Defined Types'
end
end
# Implements the Puppet defined type code object.
class PuppetStrings::Yard::CodeObjects::DefinedType < PuppetStrings::Yard::CodeObjects::Base
attr_reader :statement
attr_reader :parameters
# Initializes a Puppet defined type code object.
# @param [PuppetStrings::Parsers::DefinedTypeStatement] statement The defined type statement that was parsed.
# @return [void]
def initialize(statement)
@statement = statement
@parameters = statement.parameters.map { |p| [p.name, p.value] }
super(PuppetStrings::Yard::CodeObjects::DefinedTypes.instance, statement.name)
end
# Gets the type of the code object.
# @return Returns the type of the code object.
def type
:puppet_defined_type
end
# Gets the source of the code object.
# @return Returns the source of the code object.
def source
@statement.source
end
end

View File

@ -3,5 +3,6 @@ module PuppetStrings::Yard::Handlers
# The module for custom Puppet YARD handlers.
module Puppet
require 'puppet-strings/yard/handlers/puppet/class_handler'
require 'puppet-strings/yard/handlers/puppet/defined_type_handler'
end
end

View File

@ -0,0 +1,23 @@
require 'puppet-strings/yard/handlers/puppet/base'
require 'puppet-strings/yard/parsers'
require 'puppet-strings/yard/code_objects'
# Implements the handler for Puppet defined types.
class PuppetStrings::Yard::Handlers::Puppet::DefinedTypeHandler < PuppetStrings::Yard::Handlers::Puppet::Base
handles PuppetStrings::Yard::Parsers::Puppet::DefinedTypeStatement
process do
# Register the object
object = PuppetStrings::Yard::CodeObjects::DefinedType.new(statement)
register object
# Log a warning if missing documentation
log.warn "Missing documentation for Puppet defined type '#{object.name}' at #{statement.file}:#{statement.line}." if object.docstring.empty?
# Set the parameter types
set_parameter_types(object)
# Mark the defined type as public if it doesn't already have an api tag
object.add_tag YARD::Tags::Tag.new(:api, 'public') unless object.has_tag? :api
end
end

View File

@ -0,0 +1,9 @@
<% even = false %>
<% @items.each do |item| %>
<li id="object_<%=item.path%>" class="<%= even ? 'even' : 'odd' %>">
<div class="item">
<%= linkify item, h(item.name(true)) %>
</div>
</li>
<% even = !even %>
<% end %>

View File

@ -7,6 +7,15 @@ def generate_puppet_class_list
generate_list_contents
end
# Generates the searchable Puppet defined type list.
# @return [void]
def generate_puppet_defined_type_list
@items = Registry.all(:puppet_defined_type).sort_by {|dt| dt.name.to_s }
@list_title = 'Defined Type List'
@list_type = 'puppet_defined_type'
generate_list_contents
end
# Generates the searchable Ruby method list.
# @return [void]
def generate_method_list

View File

@ -4,7 +4,7 @@ def init
case object
when '_index.html'
@page_title = options.title
sections :layout, [:index, [:listing, [:classes, :files, :objects]]]
sections :layout, [:index, [:listing, [:classes, :defined_types, :files, :objects]]]
else
super
end
@ -30,6 +30,10 @@ def layout
@nav_url = url_for_list('puppet_class')
@page_title = "Puppet Class: #{object.name}"
@path = object.path
when PuppetStrings::Yard::CodeObjects::DefinedType
@nav_url = url_for_list('puppet_defined_type')
@page_title = "Defined Type: #{object.name}"
@path = object.path
else
@path = object.path
end
@ -46,6 +50,11 @@ def create_menu_lists
title: 'Puppet Classes',
search_title: 'Puppet Classes'
},
{
type: 'puppet_defined_type',
title: 'Defined Types',
search_title: 'Defined Types',
},
{
type: 'class',
title: 'Ruby Classes',
@ -95,6 +104,14 @@ def classes
erb(:objects)
end
# Renders the defined types section.
# @return [String] Returns the rendered section.
def defined_types
@title = 'Defined Type Listing A-Z'
@objects_by_letter = objects_by_letter(:puppet_defined_type)
erb(:objects)
end
# Renders the objects section.
# @return [String] Returns the rendered section.
def objects

View File

@ -0,0 +1,10 @@
<div class="box_info">
<dl>
<dt>Defined in:</dt>
<dd>
<%= object.file %><% if object.files.size > 1 %><span class="defines">,<br />
<%= object.files[1..-1].map {|f| f.first }.join(",<br /> ") %></div>
<% end %>
</dd>
</dl>
</div>

View File

@ -0,0 +1 @@
<h1>Defined Type: <%= object.name %></h1>

View File

@ -0,0 +1,6 @@
<h2>Overview</h2>
<div class="docstring">
<div class="discussion">
<%= htmlify(object.docstring) %>
</div>
</div>

View File

@ -0,0 +1,5 @@
# Initializes the template.
# @return [void]
def init
sections :header, :box_info, :overview, T('tags'), :source
end

View File

@ -0,0 +1,12 @@
<div class="method_details_list">
<table class="source_code">
<tr>
<td>
<pre class="lines"><%= "\n\n\n" %><%= h format_lines(object) %></pre>
</td>
<td>
<pre class="code"><span class="info file"># File '<%= h object.file %>'<% if object.line %>, line <%= object.line %><% end %></span><%= "\n\n" %><%= html_syntax_highlight object.source %></pre>
</td>
</tr>
</table>
</div>

View File

@ -3,6 +3,6 @@
def param
tag(:param) if
object.type == :method ||
object.type == :puppet_class
object.type == :puppet_class ||
object.type == :puppet_defined_type
end