adding mandatory fields to the account creation form, Fixes #132

bureau/admin/adm_add.php

@@ -1,15 +1,10 @@
 <?php
 /*
- $Id: adm_add.php,v 1.9 2006/01/24 05:03:30 joe Exp $
+ adm_add.php
  ----------------------------------------------------------------------
  AlternC - Web Hosting System
- Copyright (C) 2006 Le r<EFBFBD>seau Koumbit Inc.
+ Copyright (C) 2002-2017 by the AlternC Development Team.
- http://koumbit.org/
+ https://alternc.com/
- Copyright (C) 2002 by the AlternC Development Team.
- http://alternc.org/
- ----------------------------------------------------------------------
- Based on:
- Valentin Lacambre's web hosting softwares: http://altern.org/
  ----------------------------------------------------------------------
  LICENSE
 
@@ -26,7 +21,7 @@
  To read the license please visit http://www.gnu.org/copyleft/gpl.html
  ----------------------------------------------------------------------
  Original Author of file: Benjamin Sonntag
- Purpose of file: Member managment
+ Purpose of file: new Member managment
  ----------------------------------------------------------------------
 */
 require_once("../class/config.php");
@@ -61,20 +56,17 @@ if (isset($error) && $error) {
 ?>
 <form method="post" action="adm_doadd.php" id="main" name="main" autocomplete="off">
   <?php csrf_get(); ?>
-<!-- honeypot fields -->
-<input type="text" style="display: none" id="fakeUsername" name="fakeUsername" value="" />
-<input type="password" style="display: none" id="fakePassword" name="fakePassword" value="" />
 
 <table class="tedit">
-<tr><th><label for="login"><?php __("Username"); ?></label></th><td>
+<tr><th><label for="login"><?php __("Username"); ?></label><span class="mandatory">*</span></th><td>
-	<input type="text" class="int" name="login" id="login" value="<?php ehe($login); ?>" size="20" maxlength="16" />
+	<input type="text" class="int" name="login" id="login" autocomplete="off" value="<?php ehe($login); ?>" size="20" maxlength="16" />
 </td></tr>
 <tr>
-	<th><label for="pass"><?php __("Initial password"); ?></label></th>
+	<th><label for="pass"><?php __("Initial password"); ?></label><span class="mandatory">*</span></th>
 	<td><input type="password" id="pass" name="pass" autocomplete="off" class="int" value="<?php ehe($pass); ?>" size="20" maxlength="64" /><?php display_div_generate_password(DEFAULT_PASS_SIZE,"#pass","#passconf"); ?></td>
 </tr>
 <tr>
-	<th><label for="passconf"><?php __("Confirm password"); ?></label></th>
+	<th><label for="passconf"><?php __("Confirm password"); ?></label><span class="mandatory">*</span></th>
 	<td><input type="password" id="passconf" name="passconf" autocomplete="off" class="int" value="<?php ehe($passconf); ?>" size="20" maxlength="64" /></td>
 </tr>
 <tr>
@@ -93,7 +85,7 @@ if (isset($error) && $error) {
 	<td><input class="int" type="text" id="nom" name="nom" value="<?php ehe($nom); ?>" size="16" maxlength="128" />&nbsp;/&nbsp;<input type="text" name="prenom" id="prenom" value="<?php ehe($prenom); ?>" class="int" size="16" maxlength="128" /></td>
 </tr>
 <tr>
-	<th><label for="nmail"><?php __("Email address"); ?></label></th>
+	<th><label for="nmail"><?php __("Email address"); ?></label><span class="mandatory">*</span></th>
 	<td><input type="text" name="nmail" id="nmail" class="int" value="<?php ehe($nmail); ?>" size="30" maxlength="128" /></td>
 </tr>
 <tr>
@@ -107,7 +99,7 @@ if (isset($error) && $error) {
 <tr>
     <th>
         <?php 
-          __("Wich database server for this user ?");
+          __("Associate this new user to this database server:");
           echo "<br/>";
           echo "<i>"._("Warning: you can't change it after the creation of the user.")."</i>";
         ?>

bureau/admin/adm_doadd.php

@@ -1,9 +1,10 @@
 <?php
 /*
+ adm_doadd.php
  ----------------------------------------------------------------------
  AlternC - Web Hosting System
- Copyright (C) 2000-2012 by the AlternC Development Team.
+ Copyright (C) 2002-2017 by the AlternC Development Team.
- https://alternc.org/
+ https://alternc.com/
  ----------------------------------------------------------------------
  LICENSE
 
@@ -19,6 +20,9 @@
 
  To read the license please visit http://www.gnu.org/copyleft/gpl.html
  ----------------------------------------------------------------------
+ Original Author of file: Benjamin Sonntag
+ Purpose of file: validate and create a new member
+ ----------------------------------------------------------------------
 */
 require_once("../class/config.php");
 

bureau/admin/adm_list.php

@@ -1,11 +1,10 @@
 <?php
 /*
+ mem_admin.php
  ----------------------------------------------------------------------
  AlternC - Web Hosting System
-  Copyright (C) 2006 Le r<EFBFBD>seau Koumbit Inc.
+ Copyright (C) 2002-2017 by the AlternC Development Team.
-  http://koumbit.org/
+ https://alternc.com/
-  Copyright (C) 2002 by the AlternC Development Team.
-  http://alternc.org/
  ----------------------------------------------------------------------
  LICENSE
 

bureau/admin/mem_admin.php

@@ -1,13 +1,10 @@
 <?php
 /*
- $Id: mem_admin.php,v 1.2 2003/06/10 08:18:26 root Exp $
+ mem_admin.php
  ----------------------------------------------------------------------
  AlternC - Web Hosting System
- Copyright (C) 2002 by the AlternC Development Team.
+ Copyright (C) 2002-2017 by the AlternC Development Team.
- http://alternc.org/
+ https://alternc.com/
- ----------------------------------------------------------------------
- Based on:
- Valentin Lacambre's web hosting softwares: http://altern.org/
  ----------------------------------------------------------------------
  LICENSE
 

bureau/admin/styles/style.css

@@ -379,6 +379,14 @@ img {
   color: red;
 }
 
+.mandatory {
+  color: red;
+  font-weight: bold;
+  vertical-align: super;
+  font-size: small;
+  line-height: normal;
+}
+
 .code {
   font-size: 16px;
   font-family: Courier New, Fixed;

bureau/class/m_admin.php

@@ -587,12 +587,12 @@ class m_admin {
             return false;
         }
         if (($login == "") || ($pass == "")) {
-            $err->raise("admin", _("All fields are mandatory"));
+            $err->raise("admin", _("Please fill all mandatory fields"));
             return false;
         }
         if (!$force) {
             if ($mail == "") {
-                $err->raise("admin", _("All fields are mandatory"));
+                $err->raise("admin", _("Please fill all mandatory fields"));
                 return false;
             }
             //@todo remove cf functions.php
@@ -641,17 +641,10 @@ class m_admin {
 
             // Triggering hooks
             $mem->su($uid);
-            // TODO: old hook method FIXME: when unused remove this
+
-            /*
-              foreach($classes as $c) {
-              if (method_exists($GLOBALS[$c],"alternc_add_member")) {
-              $GLOBALS[$c]->alternc_add_member();
-              }
-              }
-             */
             $hooks->invoke("alternc_add_member");
             // New hook way
-            $hooks->invoke("hook_admin_add_member", array(), array('quota')); // First !!! The quota !!! Etherway, we can't be sure to be able to create all
+            $hooks->invoke("hook_admin_add_member", array(), array('quota')); // First !!! The quota !!! Eitherway, we can't be sure to be able to create all
             $hooks->invoke("hook_admin_add_member");
             $mem->unsu();