use escapeshellarg() properly and in both functions.

This commit is contained in:
Antoine Beaupré 2008-01-22 02:24:59 +00:00
parent 3de628ccb2
commit 48871eb7d4
1 changed files with 6 additions and 2 deletions

View File

@ -428,6 +428,8 @@ class m_bro {
$err->raise("bro",1); $err->raise("bro",1);
return false; return false;
} }
$file = escapeshellarg($file);
$dest = escapeshellarg($dest);
if ($i == 0) { if ($i == 0) {
#TODO new version of tar supports `tar xf ...` so there is no #TODO new version of tar supports `tar xf ...` so there is no
# need to specify the compression format # need to specify the compression format
@ -534,8 +536,10 @@ class m_bro {
*/ */
// Last step // Copy -R // Last step // Copy -R
$src = escapeshellarg($this->convertabsolute($src)); $src = $this->convertabsolute($src);
$dest = escapeshellarg($this->convertabsolute($dest)); $dest = $this->convertabsolute($dest);
$src = escapeshellarg($src);
$dest = escapeshellarg($dest);
if (!$src || !$dest) { if (!$src || !$dest) {
$err->raise("bro",1); $err->raise("bro",1);
return false; return false;